[webkit-reviews] review granted: [Bug 120211] [CSS Shapes] Improve the performance of image valued shapes : [Attachment 211223] Patch

[bugzilla-daemon at webkit.org]

Alexandru Chiculita <achicu at adobe.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 120211: [CSS Shapes] Improve the performance of image valued shapes
https://bugs.webkit.org/show_bug.cgi?id=120211

Attachment 211223: Patch
https://bugs.webkit.org/attachment.cgi?id=211223&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211223&action=review


> Source/WebCore/rendering/shapes/RasterShape.cpp:220
> +    float minY = std::max<float>(intervals.bounds().y(),
minLogicalIntervalTop);

There's no reason to have this outside the intervals.firstIncludedIntervalY
method. It actually knows too much about how the method is supposed to work.

> Source/WebCore/rendering/shapes/RasterShape.h:54
> +    const IntShapeIntervals& getIntervals(int y) const

This method is not needed outside RasterShapeIntervals. Make it private.