[webkit-reviews] review requested: [Bug 118758] fourthTier: Change JSStack to grow from high to low addresses : [Attachment 211359] Patch addressing review and ewe bot issues
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 11 15:20:28 PDT 2013
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 118758: fourthTier: Change JSStack to grow from high to low addresses
https://bugs.webkit.org/show_bug.cgi?id=118758
Attachment 211359: Patch addressing review and ewe bot issues
https://bugs.webkit.org/attachment.cgi?id=211359&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
Removed the "if (symbolTable())" check in CodeBlock.cpp.
Have speculative fixes for Qt compile failure (moved definition of
trustedImm32ForShift() up in the file).
Have speculative fix for failure found in mac-wk2-ews - Made stackOffset int in
CodeOrigin::stackOffset() and inlinedFrameOffset in StackVisitor.cpp.
More information about the webkit-reviews
mailing list