[webkit-reviews] review granted: [Bug 101047] REGRESSION (r132516): Javascript menu text incorrectly disappearing and reappearing : [Attachment 209442] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Zalan Bujtas
<zalan at apple.com>'s request for review:
Bug 101047: REGRESSION (r132516): Javascript menu text incorrectly disappearing
and reappearing
https://bugs.webkit.org/show_bug.cgi?id=101047

Attachment 209442: Patch
https://bugs.webkit.org/attachment.cgi?id=209442&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209442&action=review


> Source/WebCore/rendering/RenderLayer.cpp:1189
> +	       layerNeedsRebuild =
backing->updateAncestorClippingLayer(compositor->clippedByAncestor(child)) ||
layerNeedsRebuild;

I'd prefer to write this as
if (backing->updateAncestorClippingLayer(compositor->clippedByAncestor(child)))

  layerNeedsRebuild = true;

> Source/WebCore/rendering/RenderLayer.cpp:6242
> +		   compositor->scheduleCompositingLayerUpdate();

You don't need to schedule an update. We'll update compositing at the end of
this style update or the subsequent layout.