[webkit-reviews] review granted: [Bug 121180] [Windows] Avoid converting from IntSize->SIZE->IntSize : [Attachment 211353] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 11 14:57:46 PDT 2013


Anders Carlsson <andersca at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 121180: [Windows] Avoid converting from IntSize->SIZE->IntSize
https://bugs.webkit.org/show_bug.cgi?id=121180

Attachment 211353: Patch
https://bugs.webkit.org/attachment.cgi?id=211353&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211353&action=review


> Source/WebCore/platform/graphics/BitmapImage.h:153
> +    virtual bool getHBITMAPOfSize(HBITMAP, const IntSize*);

I think this should take a const IntSize.

> Source/WebCore/platform/graphics/Image.h:164
> +    virtual bool getHBITMAPOfSize(HBITMAP, const IntSize*) { return false; }


Ditto. And use override.


More information about the webkit-reviews mailing list