[webkit-reviews] review granted: [Bug 120875] MediaStream API: Remove LocalMediaStream : [Attachment 211334] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 120875: MediaStream API: Remove LocalMediaStream
https://bugs.webkit.org/show_bug.cgi?id=120875

Attachment 211334: Patch
https://bugs.webkit.org/attachment.cgi?id=211334&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211334&action=review


r=me with the changes noted.

> Source/WebCore/ChangeLog:8
> +	   https://bugs.webkit.org/show_bug.cgi?id=120875
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Existing tests were updated.

This should reference the Blink change this was merged from.

> Source/WebCore/Modules/mediastream/MediaStream.h:-53
> -    // DEPRECATED
> -    String label() const { return m_descriptor->id(); }
> -

This is unrelated, it should be removed in another patch.

> Source/WebCore/Modules/mediastream/MediaStream.idl:-37
> -    // DEPRECATED
> -    readonly attribute DOMString label;
> -

Ditto