[webkit-reviews] review granted: [Bug 121100] [Windows] Revise GDI Create Functions to use GDIObject Smart Pointer : [Attachment 211341] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 121100: [Windows] Revise GDI Create Functions to use GDIObject Smart
Pointer
https://bugs.webkit.org/show_bug.cgi?id=121100

Attachment 211341: Patch
https://bugs.webkit.org/attachment.cgi?id=211341&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211341&action=review


> Source/WebCore/platform/graphics/win/FontCacheWin.cpp:491
> +	   return GDIObject<HFONT>();

If you add a GDIObject constructor that takes std::nullptr_t you can just
return nullptr here.

> Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp:58
> +    ::SelectObject(hdc, m_font.get()->get());

I think SharedGDIObject’s get function should just return T, then this would
just be m_font.get().

> Source/WebCore/platform/graphics/win/FontPlatformDataWin.cpp:69
> +	   platformDataInit(m_font.get()->get(), size, hdc, faceName);

Same thing here.