[webkit-reviews] review granted: [Bug 118758] fourthTier: Change JSStack to grow from high to low addresses : [Attachment 211338] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 118758: fourthTier: Change JSStack to grow from high to low addresses
https://bugs.webkit.org/show_bug.cgi?id=118758

Attachment 211338: Patch
https://bugs.webkit.org/attachment.cgi?id=211338&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211338&action=review


> Source/JavaScriptCore/bytecode/CodeBlock.cpp:3434
> +    if (symbolTable()) {
> +	   ConcurrentJITLocker locker(symbolTable()->m_lock);
> +	   SymbolTable::Map::iterator end = symbolTable()->end(locker);
> +	   for (SymbolTable::Map::iterator ptr = symbolTable()->begin(locker);
ptr != end; ++ptr) {
> +	       if (ptr->value.getIndex() == registerNumber) {
> +		   // FIXME: This won't work from the compilation thread.
> +		   // https://bugs.webkit.org/show_bug.cgi?id=115300
> +		   return String(ptr->key);
> +	       }

Why is this change necessary in this patch?

> Source/JavaScriptCore/runtime/JSArray.h:312
> -
> +    

grrrr

> Source/JavaScriptCore/runtime/JSArray.h:317
> -
> +    

grrrrr

> Source/JavaScriptCore/runtime/Operations.h:90
> +    for (int i = 0; i < static_cast<int>(count); ++i) {
> +	   JSValue v = strings[-i].jsValue();

I would rather i remain an unsigned, and the strings[-i] be
strings[-static_cat<int>(i)]

> Source/WTF/wtf/DataLog.cpp:43
> -#define DATA_LOG_TO_FILE 0
> +#define DATA_LOG_TO_FILE 1

Whoops :D