[webkit-reviews] review granted: [Bug 121171] Remove TimelineTraceEventProcessor since no current ports use it : [Attachment 211330] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 121171: Remove TimelineTraceEventProcessor since no current ports use it
https://bugs.webkit.org/show_bug.cgi?id=121171

Attachment 211330: Patch
https://bugs.webkit.org/attachment.cgi?id=211330&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211330&action=review


r=me

> Source/WebCore/inspector/TimelineTraceEventProcessor.cpp:-167
> -    registerHandler(InstrumentationEvents::BeginFrame, TracePhaseInstant,
&TimelineTraceEventProcessor::onBeginFrame);
> -    registerHandler(InstrumentationEvents::PaintLayer, TracePhaseBegin,
&TimelineTraceEventProcessor::onPaintLayerBegin);
> -    registerHandler(InstrumentationEvents::PaintLayer, TracePhaseEnd,
&TimelineTraceEventProcessor::onPaintLayerEnd);
> -    registerHandler(InstrumentationEvents::RasterTask, TracePhaseBegin,
&TimelineTraceEventProcessor::onRasterTaskBegin);
> -    registerHandler(InstrumentationEvents::RasterTask, TracePhaseEnd,
&TimelineTraceEventProcessor::onRasterTaskEnd);
> -    registerHandler(InstrumentationEvents::Layer, TracePhaseDeleteObject,
&TimelineTraceEventProcessor::onLayerDeleted);
> -    registerHandler(InstrumentationEvents::Paint, TracePhaseInstant,
&TimelineTraceEventProcessor::onPaint);

I think this was the only user of InstrumentationEvents and
InstrumentationEventArguments. You can remove the enum / strings in
InspectorInstrumentation.*:

    inspector/InspectorInstrumentation.cpp
    1390:namespace InstrumentationEvents {
    1398:namespace InstrumentationEventArguments {

    inspector/InspectorInstrumentation.h
    515:namespace InstrumentationEvents {
    523:namespace InstrumentationEventArguments {