[webkit-reviews] review requested: [Bug 121107] Move LineWidth out of RenderBlockLineLayout : [Attachment 211329] proposed patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 121107: Move LineWidth out of RenderBlockLineLayout
https://bugs.webkit.org/show_bug.cgi?id=121107

Attachment 211329: proposed patch
https://bugs.webkit.org/attachment.cgi?id=211329&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>
(In reply to comment #6)
> (From update of attachment 211253 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=211253&action=review
> 
> > Source/WebCore/rendering/LineWidth.h:34
> > +#include "RenderBlock.h"
> > +#include "RenderRubyRun.h"
> 
> Do either of these really need to be in the header?

For now, yes. I'd like to move logicalHeightForLine to RenderBlock in a
separate patch, I'll remove the includes along with that patch.

> > Source/WebCore/rendering/LineWidth.h:48
> > +	 return max<LayoutUnit>(replacedHeight, block->lineHeight(isFirstLine,
block->isHorizontalWritingMode() ? HorizontalLine : VerticalLine,
PositionOfInteriorLineBoxes));
> 
> I am surprised this compiles without the std::.  I would add it though.

Added.

> > Source/WebCore/rendering/LineWidth.h:79
> > +	 RenderBlock* m_block;
> 
> It looks like this is never null, can we make it a RenderBlock&?

Done.