[webkit-reviews] review denied: [Bug 120647] [GTK] Move to the new web inspector : [Attachment 211070] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 11 08:49:36 PDT 2013
Anders Carlsson <andersca at apple.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 120647: [GTK] Move to the new web inspector
https://bugs.webkit.org/show_bug.cgi?id=120647
Attachment 211070: Patch
https://bugs.webkit.org/attachment.cgi?id=211070&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211070&action=review
> Source/WebCore/platform/gtk/KURLGtk.cpp:33
> +String KURL::fileSystemPath() const
> +{
> + if (!isValid())
> + return String();
> +
> + if (isLocalFile() || protocolIs("resource"))
> + return decodeURLEscapeSequences(path());
> +
> + return String();
I don't think we should fragment the meaning of fileSystemPath like this.
Pretty sure that new files should use the BSD license too.
More information about the webkit-reviews
mailing list