[webkit-reviews] review granted: [Bug 121149] [ATK] Adds mapping MenuItemRadioRole to ATK : [Attachment 211292] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 11 03:10:56 PDT 2013
Mario Sanchez Prada <mario at webkit.org> has granted Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 121149: [ATK] Adds mapping MenuItemRadioRole to ATK
https://bugs.webkit.org/show_bug.cgi?id=121149
Attachment 211292: Patch
https://bugs.webkit.org/attachment.cgi?id=211292&action=review
------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211292&action=review
Looks good to me, but there's an extra line that should be removed before
landing
> LayoutTests/ChangeLog:11
> + * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt:
Thanks for adding the GTK expectation
> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:234
> +
Wrong extra line
More information about the webkit-reviews
mailing list