[webkit-reviews] review denied: [Bug 120612] WebKit crashes when trying to send a msg via 'today's birthdays' dialogue box on Facebook : [Attachment 211262] removed extra whitespace line

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Chris Curtis
<chris_curtis at apple.com>'s request for review:
Bug 120612: WebKit crashes when trying to send a msg via 'today's birthdays'
dialogue box on Facebook
https://bugs.webkit.org/show_bug.cgi?id=120612

Attachment 211262: removed extra whitespace line 
https://bugs.webkit.org/attachment.cgi?id=211262&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211262&action=review


Looks good, but please fix these details.

> Source/JavaScriptCore/API/tests/testapi.c:1064
> +    JSClassRef globalObjectClass =
JSClassCreate(&globalObjectClassDefinition);

This needs a corresponding JSClassRelease.

> Source/JavaScriptCore/API/tests/testapi.c:1065
> +    context = JSGlobalContextCreateInGroup(NULL, globalObjectClass);

This needs a corresponding JSContextRelease. Is it OK that we're overwriting
the global here? Maybe this should be a local.

> Source/JavaScriptCore/API/tests/testapi.c:1066
> +    JSContextGetGlobalObject(context);

You can remove this line.