[webkit-reviews] review granted: [Bug 120372] AX: AXValue/AXMenuItemMarkChar not defined for menuitemradio (should be false (0) with aria-checked=mixed | undefined) : [Attachment 211104] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 120372: AX: AXValue/AXMenuItemMarkChar not defined for menuitemradio
(should be false (0) with aria-checked=mixed | undefined)
https://bugs.webkit.org/show_bug.cgi?id=120372

Attachment 211104: patch
https://bugs.webkit.org/attachment.cgi?id=211104&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211104&action=review


Looks good to me. Just fix the path for the JS resources before landing, and
maybe consider my comment about the duplicate line.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1212
>	   [tempArray addObject:NSAccessibilitySelectedAttribute];
> +	   [tempArray addObject:NSAccessibilitySelectedAttribute];

Are you adding this duplicate line intentionally, or is it a mistake?

> LayoutTests/platform/mac/accessibility/menu-item-values.html:4
> +<script src="../../../fast/js/resources/js-test-pre.js"></script>

This path should be ../../../resources/js-test-pre.js now, as those JS
resources have been moved there along with r155411

> LayoutTests/platform/mac/accessibility/menu-item-values.html:46
> +<script src="../../../fast/js/resources/js-test-post.js"></script>

Same here, but for ../../../resources/js-test-post.js