[webkit-reviews] review granted: [Bug 120783] Custom CSS cursors do not use -webkit-image-set on retina displays : [Attachment 211167] Patch to use -webkit-image-set for custom CSS cursors

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted evan.exe at gmail.com's request for
review:
Bug 120783: Custom CSS cursors do not use -webkit-image-set on retina displays
https://bugs.webkit.org/show_bug.cgi?id=120783

Attachment 211167: Patch to use -webkit-image-set for custom CSS cursors
https://bugs.webkit.org/attachment.cgi?id=211167&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211167&action=review


> Source/WebCore/platform/mac/CursorMac.mm:56
> +    NSSize size = NSMakeSize(image->width() / scale, image->height() /
scale);

Did you test with a cursor that has a non-integral pixel height? Like a 31x31
pixel cursor with a 2X scale factor?

> Source/WebKit2/ChangeLog:13
> +	   (CoreIPC::::encode):
> +	   (CoreIPC::::decode):

Should fix the incorrect function names here. It should be:

    (CoreIPC::ArgumentCoder<Cursor>::encode):

Too bad the script got it wrong, but it would be great if you fixed it.