[webkit-reviews] review granted: [Bug 120651] [mac] PDFDocumentImage should use PDFKit to draw : [Attachment 211178] extern

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 120651: [mac] PDFDocumentImage should use PDFKit to draw
https://bugs.webkit.org/show_bug.cgi?id=120651

Attachment 211178: extern
https://bugs.webkit.org/attachment.cgi?id=211178&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211178&action=review


r=me assuming that there are no flaky tests introduced locally (also when
running some subsets of pixel tests like in comment 23). EWS won't tell us.

> Source/WebCore/platform/graphics/mac/PDFDocumentImageMac.mm:81
> +    // These states can be mutated by PDFKit but are not saved
> +    // on the context's state stack. (<rdar://problem/14951759>)

Do we need the same in PDFPlugin?