[webkit-reviews] review granted: [Bug 121099] [WK2][GTK] Frequent crashes when showing context menus in Debug builds : [Attachment 211208] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 121099: [WK2][GTK] Frequent crashes when showing context menus in Debug
builds
https://bugs.webkit.org/show_bug.cgi?id=121099

Attachment 211208: Patch
https://bugs.webkit.org/attachment.cgi?id=211208&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211208&action=review


LGTM

> Source/WebKit2/UIProcess/gtk/WebContextMenuProxyGtk.cpp:174
> +    for (HashMap<unsigned long, GtkAction*>::const_iterator iter =
m_signalHandlers.begin(); iter != m_signalHandlers.end(); ++iter)
> +	   g_signal_handler_disconnect(iter->value, iter->key);

I'm not C++ expert, but now that we are using C++ 11 features I wonder if we
could use auto here.