[webkit-reviews] review granted: [Bug 98370] [GTK] accessibility/loading-iframe-sends-notification.html is failing : [Attachment 211203] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Denis Nomiyama (dnomi)
<d.nomiyama at samsung.com>'s request for review:
Bug 98370: [GTK] accessibility/loading-iframe-sends-notification.html is
failing
https://bugs.webkit.org/show_bug.cgi?id=98370

Attachment 211203: Patch
https://bugs.webkit.org/attachment.cgi?id=211203&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211203&action=review


> Source/WebCore/ChangeLog:10
> +	   No new tests are required because this feature will use an existing
a11y

I'm not a fan of using a11y to describe accessibility, since it's a
colloquialism that may not be familiar to the casual observer

> Source/WebCore/accessibility/atk/AXObjectCacheAtk.cpp:169
> +    else if (notification == AXInvalidStatusChanged)

we should think about changing this if/else chain to a switch statement in the
future