[webkit-reviews] review granted: [Bug 120786] Mouseenter/-leave not triggered when element under cursor is moved/removed : [Attachment 211025] Patch

[bugzilla-daemon at webkit.org]

Antonio Gomes <tonikitoo at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 120786: Mouseenter/-leave not triggered when element under cursor is
moved/removed
https://bugs.webkit.org/show_bug.cgi?id=120786

Attachment 211025: Patch
https://bugs.webkit.org/attachment.cgi?id=211025&action=review

------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=211025&action=review


Change itself looks good. I am keeping cq- as test might get improved a bit.

> LayoutTests/fast/events/mouseenterleave-detached-element.html:20
> +    document.addEventListener('mouseleave', logMouseEvent, true);

is there any "mouselevave" event expected to be thrown?

> LayoutTests/fast/events/mouseenterleave-detached-element.html:26
> +	   window.setTimeout(endTest, 200);

200 is quite a lot :(

If we know exactly how many events are being thrown, can we use a count
instead, and call endTest when the count reaches the expected amount?