[webkit-reviews] review granted: [Bug 121087] toFooElement() should use static_cast, not reinterpret_cast. : [Attachment 211184] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 10 01:51:11 PDT 2013
Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 121087: toFooElement() should use static_cast, not reinterpret_cast.
https://bugs.webkit.org/show_bug.cgi?id=121087
Attachment 211184: Patch
https://bugs.webkit.org/attachment.cgi?id=211184&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=211184&action=review
> Source/WebCore/ChangeLog:19
> + - void toFooElement(constNode*)
missing space
> Source/WebCore/dom/Node.h:786
> +void to##NodeSubclassName(const NodeSubclassName*); \
> +void to##NodeSubclassName(const NodeSubclassName&);
> +
Anders suggested to use WTF_DELETE_FUNCTION. Does that not work?
More information about the webkit-reviews
mailing list