[webkit-reviews] review granted: [Bug 93607] Web Inspector: [JSC] Caught exception is treated as uncaught : [Attachment 211132] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 93607: Web Inspector: [JSC] Caught exception is treated as uncaught
https://bugs.webkit.org/show_bug.cgi?id=93607

Attachment 211132: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=211132&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211132&action=review


Thanks, Joe!

r=me, but please fix the logic error below, and add a test for it.

> Source/JavaScriptCore/interpreter/Interpreter.cpp:582
> +	   if (!codeBlock)
> +	       return StackVisitor::Done;

I think you want StackVisitor::Continue here.

Consider this stack:
    js function with try/catch scope => Array.prototype.map => js function =>
throw
CodeBlock is null for host functions. Therefore, when you see
Array.prototype.map, you'll return StackVisitor::Done and conclude that there's
no handler. But there is a handler, in the function that called map.