[webkit-reviews] review granted: [Bug 121056] Add local to/from operand helpers similar to argument to/from operand : [Attachment 211119] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 121056: Add local to/from operand helpers similar to argument to/from
operand
https://bugs.webkit.org/show_bug.cgi?id=121056

Attachment 211119: Patch
https://bugs.webkit.org/attachment.cgi?id=211119&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211119&action=review


r=me

> Source/JavaScriptCore/ChangeLog:10
> +	   registers in intended instead of the actual virtual register offset.
 When the stack is

"in" should be "is".

"a index" should be "an index".

I think you mean "index into a data structure", or something like that. "index
to the local registers" implies some kind of memory offset in a register bank,
which the opposite of what you're doing.

> Source/JavaScriptCore/ChangeLog:18
> +	   * bytecode/CodeBlock.cpp:
> +	   (JSC::CodeBlock::registerName):
> +	   * bytecode/CodeBlock.h:
> +	   (JSC::CodeBlock::isCaptured):

Giant empty list not so helpful.

> Source/JavaScriptCore/dfg/DFGScoreBoard.h:92
> +	       return (VirtualRegister)localToOperand(index);

I see this cast a lot. Why doesn't localToOperand return the VirtualRegister
type?