[webkit-reviews] review granted: [Bug 121045] CopiedSpace::startedCopying should not call MarkedSpace::capacity : [Attachment 211123] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 17:18:21 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 121045: CopiedSpace::startedCopying should not call MarkedSpace::capacity
https://bugs.webkit.org/show_bug.cgi?id=121045

Attachment 211123: Patch
https://bugs.webkit.org/attachment.cgi?id=211123&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211123&action=review


r=me

> Source/JavaScriptCore/heap/MarkedSpace.h:135
> +    size_t m_totalCapacity;

I think "capacity" is a slightly better name here. We don't have a concept of
"partial capacity" in this class.


More information about the webkit-reviews mailing list