[webkit-reviews] review denied: [Bug 121046] Web Inspector: Drag onto Web Inspector to open in Inspected Target : [Attachment 211085] [PATCH] Attempt 1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 14:16:44 PDT 2013

Joseph Pecoraro <joepeck at webkit.org> has denied  review:
Bug 121046: Web Inspector: Drag onto Web Inspector to open in Inspected Target

Attachment 211085: [PATCH] Attempt 1

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
So this was my first attempt. To just load the content inside of WebCore. This
successfully handles loading the content, but doesn't deal with the
back/forward list as nicely as I would like.


  - URLs (e.g. from Safari's address bar, or dragging a hyperlink)
  - .html, .txt, and other file types that show up in
  - .webarchives special path
  - .webloc plist files (e.g a URL dragged from Safari to Desktop)


  - Opening a page through this method replaces the existing back/forward
history item instead of making a new item
    - this means if you select the URL in the back/forward list, the URL will
be loaded instead of the substitute content we provided
  - The dragged page doesn't have a nice URL, currently I'm using about:blank
  - Testing via inspector-protocol is not possible yet, the frontend is,
cleverly, opened inside of a window.open(…) Page, so after navigating the
original page the frontend goes away and all test control of the frontend is
lost =)

The advise I was given was to instead switch to custom protocol handlers. That
should be able to fix the non-test issues, but also means by moving code out of
WebCore into port specific territory we lose a cross platform implementation.

More information about the webkit-reviews mailing list