[webkit-reviews] review granted: [Bug 120779] Move Floats out of RenderBlock : [Attachment 211073] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 13:32:21 PDT 2013


Alexandru Chiculita <achicu at adobe.com> has granted Bem Jones-Bey
<bjonesbe at adobe.com>'s request for review:
Bug 120779: Move Floats out of RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=120779

Attachment 211073: Patch
https://bugs.webkit.org/attachment.cgi?id=211073&action=review

------- Additional Comments from Alexandru Chiculita <achicu at adobe.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211073&action=review


r=me

> Source/WebCore/rendering/FloatingObjects.cpp:51
> +    : m_renderer(renderer)

nit: Fix indentation for the initializers.

> Source/WebCore/rendering/FloatingObjects.cpp:84
> +: m_placedFloatsTree(UninitializedTree)

Nit: ditto

> Source/WebCore/rendering/FloatingObjects.h:45
> +    : m_renderer(0)

nit: ditto

> Source/WebCore/rendering/FloatingObjects.h:63
> +    : m_renderer(0)

nit: ditto


More information about the webkit-reviews mailing list