[webkit-reviews] review granted: [Bug 119631] [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched : [Attachment 208437] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 119631: [webkitpy] perf profiler attaches to WKTR after the WebProcess was
launched
https://bugs.webkit.org/show_bug.cgi?id=119631

Attachment 208437: Patch
https://bugs.webkit.org/attachment.cgi?id=208437&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=208437&action=review


> Tools/Scripts/webkitpy/common/system/profiler.py:-162
> -	   if perf_exitcode is None:  # This should always be the case, unless
perf error'd out early.
> -	       self._host.executive.interrupt(self._perf_process.pid)
> -
> -	   perf_exitcode = self._perf_process.wait()
> -	   if perf_exitcode not in (0, -2):  # The exit code should always be
-2, as we're always interrupting perf.
> -	       print "'perf record' failed (exit code: %i), can't process
results:" % perf_exitcode
> -	       return

Who is catching the error now?

> Tools/Scripts/webkitpy/port/driver.py:218
> +	   if self._port.get_option('wrapper'):

Why don't we store this on a temporary variable?