[webkit-reviews] review granted: [Bug 120873] MediaStream API: Stop means stop : [Attachment 211044] Proposed patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 120873: MediaStream API: Stop means stop
https://bugs.webkit.org/show_bug.cgi?id=120873

Attachment 211044: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=211044&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
This seems weird. MediaStreamTrack is an ActiveDOMObject, but doesn't override
any of ActiveDOMObject's methods besides ::stop(), and doesn't call
setPendingActivity().  Why isn't MediaStream an ActiveDOMObject?  After all, it
has a m_stopped ivar too. If anything, MediaStreamSource is the active object,
but MediaStreamTrack::stop() doesn't try to stop it's associated source.

This seems highly weird, and I'm not entirely comfortable with it.  But my
problems with this method don't have much to do with this change specifically,
so LGTM with reservations.