[webkit-reviews] review granted: [Bug 105538] [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails : [Attachment 211053] Patch proposal plus new Layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 10:14:26 PDT 2013


chris fleizach <cfleizach at apple.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 105538: [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
https://bugs.webkit.org/show_bug.cgi?id=105538

Attachment 211053: Patch proposal plus new Layout test
https://bugs.webkit.org/attachment.cgi?id=211053&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211053&action=review


> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1552
> +    if (isHTMLLineBreak(childText[0]) ||
isHTMLLineBreak(builder[builder.length() - 1]))

looks like you can just 

  return !(isHTMLLineBreak() or isHTMLLineBreak())


More information about the webkit-reviews mailing list