[webkit-reviews] review granted: [Bug 121029] matchingShorthandsForLonghand builds map using a giant function : [Attachment 211045] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 9 08:57:22 PDT 2013
Anders Carlsson <andersca at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 121029: matchingShorthandsForLonghand builds map using a giant function
https://bugs.webkit.org/show_bug.cgi?id=121029
Attachment 211045: Patch
https://bugs.webkit.org/attachment.cgi?id=211045&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211045&action=review
> Source/WebCore/css/StylePropertyShorthand.cpp:598
> +static Vector<StylePropertyShorthand> makeVector(const
StylePropertyShorthand& a)
> +{
> + return Vector<StylePropertyShorthand>(1, a);
> +}
I wish we could use std::initializer_list so we wouldn't need any of these
helpers!
More information about the webkit-reviews
mailing list