[webkit-reviews] review granted: [Bug 121028] Hide Document::renderer() : [Attachment 211024] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 9 03:34:15 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 121028: Hide Document::renderer()
https://bugs.webkit.org/show_bug.cgi?id=121028

Attachment 211024: patch
https://bugs.webkit.org/attachment.cgi?id=211024&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=211024&action=review


A+, good patch, would review again!

> Source/WebCore/dom/Document.h:-546
> -    // FIXME: Remove this, callers that have a Document* should call
renderView().
> -    // Shadow the implementations on Node to provide faster access for
documents.
> -    RenderView* renderer() const { return m_renderView; }

Thanks for fixing my FIXME! :D


More information about the webkit-reviews mailing list