[webkit-reviews] review granted: [Bug 121006] Begin moving off of TypeTraits.h : [Attachment 210980] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 121006: Begin moving off of TypeTraits.h
https://bugs.webkit.org/show_bug.cgi?id=121006

Attachment 210980: Patch
https://bugs.webkit.org/attachment.cgi?id=210980&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210980&action=review


Strange failure in the EFL port. They are using an incomplete type in some
source file and somehow got away with it.

>> Source/WTF/wtf/CheckedArithmetic.h:164
>> +	template <typename Target, typename Source, bool CanElide =
std::is_same<Target, Source>::value || (sizeof(Target) > sizeof(Source)) >
struct BoundsCheckElider;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

Looks like an accidental indent happened here.