[webkit-reviews] review granted: [Bug 121005] Rename needsShadowTreeWalker : [Attachment 210976] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Sep 8 04:23:12 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 121005: Rename needsShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=121005

Attachment 210976: patch
https://bugs.webkit.org/attachment.cgi?id=210976&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210976&action=review


r=me

> Source/WebCore/ChangeLog:8
> +	   Renemane to needsNodeRenderingTraversalSlowPath.

typo

> Source/WebCore/dom/Element.cpp:1422
> +   
setNeedsNodeRenderingTraversalSlowPath(determineNeedsNodeRenderingTraversalSlow
Path(*this));

This is so long I can't read the whole line without blinking.
I don't have any better suggestions right now though :(


More information about the webkit-reviews mailing list