[webkit-reviews] review granted: [Bug 120979] Separate forward and backward paths in ComposedShadowTreeWalker : [Attachment 210937] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120979: Separate forward and backward paths in ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=120979

Attachment 210937: patch
https://bugs.webkit.org/attachment.cgi?id=210937&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210937&action=review


r=me. Almost there eh?

> Source/WebCore/dom/ComposedShadowTreeWalker.cpp:131
> +    ASSERT(node);
> +    ASSERT(node);

Maybe you should also assert that 'node' is non-null here.

> Source/WebCore/dom/ComposedShadowTreeWalker.cpp:150
>      ASSERT(node);
> -    if (Node* found = traverseSiblings(direction ==
TraversalDirectionForward ? node->nextSibling() : node->previousSibling(),
direction))
> -	   return found;
> -    return escapeFallbackContentElement(node, direction);
> +    ASSERT(node);

And here.