[webkit-reviews] review granted: [Bug 120953] Remove unnecessary sibling text renderers after attach : [Attachment 210906] fix a few bad test result updates

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 120953: Remove unnecessary sibling text renderers after attach
https://bugs.webkit.org/show_bug.cgi?id=120953

Attachment 210906: fix a few bad test result updates
https://bugs.webkit.org/attachment.cgi?id=210906&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210906&action=review


> Source/WebCore/ChangeLog:8
> +	   The current createTextRenderersForSiblingsAfterAttachIfNeeded code
only adds text renderers, never removes them. Style changes can  go either way.


Extra space before "go".

> Source/WebCore/style/StyleResolveTree.cpp:305
> +	   bool hadRenderer = !!whitespaceTextSibling.renderer();

Do you really need the !! here?

> LayoutTests/editing/selection/focus-crash-expected.txt:1
> -To run this test manually, click the "Crash me" button. 
> +To run this test manually, click the "Crash me" button.  

What's with this test? Looks like it adds whitespace?

> LayoutTests/userscripts/user-script-all-frames-expected.txt:1
> +If any thingers appear on this page, the test has failed.  

Same here.

> LayoutTests/userscripts/user-script-top-frame-only-expected.txt:1
> +Two thingers should appear on this page. Otherwise the test has failed.  

And here!