[webkit-reviews] review denied: [Bug 120350] [GTK] Cancel the current active WebKitAuthenticationRequest on load failed : [Attachment 210758] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Anton Obzhirov
<a.obzhirov at samsung.com>'s request for review:
Bug 120350: [GTK] Cancel the current active WebKitAuthenticationRequest on load
failed
https://bugs.webkit.org/show_bug.cgi?id=120350

Attachment 210758: Patch
https://bugs.webkit.org/attachment.cgi?id=210758&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210758&action=review


This looks good to me, setting r- only because of the static function. This
adds new API, so we need approval from another GTK+ port maintainer.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3081
> +void webkitWebViewResetAuthenticationRequest(WebKitWebView* webView)

This function is only used by this file, so it should be static. I'm not sure
reset is the best name, though, I would use Cancel or Clear.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:3083
> +    if (webView->priv->authenticationRequest) {

Use an early return here instead.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewPrivate.h:63
> +void webkitWebViewResetAuthenticationRequest(WebKitWebView*);

This is not needed because the function is only used in WebKitWebView.cpp