[webkit-reviews] review granted: [Bug 120910] Calculating the size of the Heap should not require walking over it : [Attachment 210827] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 120910: Calculating the size of the Heap should not require walking over it
https://bugs.webkit.org/show_bug.cgi?id=120910

Attachment 210827: Patch
https://bugs.webkit.org/attachment.cgi?id=210827&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210827&action=review


r=me

> Source/JavaScriptCore/heap/Heap.cpp:647
> +    // rather than all used (inluding dead) copied bytes, thus it's 

Should be "including".

> Source/JavaScriptCore/heap/Heap.h:254
> +	   size_t m_totalBytesVisited;
> +	   size_t m_totalBytesCopied;

Let's initialize these in the Heap constructor.