[webkit-reviews] review granted: [Bug 120904] Remove fastNew/fastDelete : [Attachment 210810] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 6 16:00:12 PDT 2013


Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 120904: Remove fastNew/fastDelete
https://bugs.webkit.org/show_bug.cgi?id=120904

Attachment 210810: Patch
https://bugs.webkit.org/attachment.cgi?id=210810&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210810&action=review


r=me, so much tasty redness!

> Source/WebCore/css/CSSSelectorList.cpp:75
> +		   // Free the underlying memory without invoking the
destructor.
> +		   operator delete (currentSelector);

This is so ugly it hurts.


More information about the webkit-reviews mailing list