[webkit-reviews] review denied: [Bug 120869] [WK2] API tests are using lot of uninitialized variables : [Attachment 210774] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 6 13:40:42 PDT 2013


Darin Adler <darin at apple.com> has denied Hugo Parente Lima
<hugo.lima at openbossa.org>'s request for review:
Bug 120869: [WK2] API tests are using lot of uninitialized variables
https://bugs.webkit.org/show_bug.cgi?id=120869

Attachment 210774: Patch
https://bugs.webkit.org/attachment.cgi?id=210774&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
These variables are all initialized, there is no problem here. C and C++
initialize globals, including ones like these, to false. There’s no need to
explicitly initialize them.

Adding these “= false” would be OK if it was some considered an important style
improvement, but in my opinion it’s not an improvement.


More information about the webkit-reviews mailing list