[webkit-reviews] review granted: [Bug 120891] Internals should always cause a layout before calling into TextIterator : [Attachment 210787] Fixes Internals

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 120891: Internals should always cause a layout before calling into
TextIterator
https://bugs.webkit.org/show_bug.cgi?id=120891

Attachment 210787: Fixes Internals
https://bugs.webkit.org/attachment.cgi?id=210787&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210787&action=review


>> Source/WebCore/ChangeLog:11
>> +	    to avoid problems in the future such as intermittent test failures.

> 
> We also call the same from WebKit, and don't update the layout. It would seem
inconsistent if we only did the in Internals.

I’m not sure what your point is. Calling without updating layout is a bug. Why
do we need to replicate that bug in our test harness? Would doing that help us
make certain kinds of tests?