[webkit-reviews] review granted: [Bug 120726] When deleting editable content, typing style should be reset when moving into another node. : [Attachment 210712] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 6 13:12:01 PDT 2013


Ryosuke Niwa <rniwa at webkit.org> has granted Arpita Bahuguna
<a.bah at samsung.com>'s request for review:
Bug 120726: When deleting editable content, typing style should be reset when
moving into another node.
https://bugs.webkit.org/show_bug.cgi?id=120726

Attachment 210712: Patch
https://bugs.webkit.org/attachment.cgi?id=210712&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=210712&action=review


> LayoutTests/editing/deleting/maintain-style-after-delete-expected.txt:3
> +Deleting 'W' in blue color and then inserting 'O'. The following markup
should show 'O' in blue color.:

We shouldn't have . before :.

> LayoutTests/editing/deleting/maintain-style-after-delete-expected.txt:9
> +Deleting the blue colored text and the preceding space and then inserting
'W'. 'W' should be not be in blue color in the following markup.:

Ditto.


More information about the webkit-reviews mailing list