[webkit-reviews] review granted: [Bug 120755] Lots of pixel tests are failing on first run, so tests cannot finish : [Attachment 210762] proposed fix

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 120755: Lots of pixel tests are failing on first run, so tests cannot
finish
https://bugs.webkit.org/show_bug.cgi?id=120755

Attachment 210762: proposed fix
https://bugs.webkit.org/attachment.cgi?id=210762&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=210762&action=review


> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:153
> -	   if self._options.pixel_tests:
> -	       self._printer.write_update("Starting pixel test helper ...")
> -	       self._port.start_helper()
> +	   self._printer.write_update("Starting pixel test helper ...")
> +	   self._port.start_helper()

We should be able to detect whether we're running a ref test or not but I
suppose we can live with it for now.
Perhaps we should do this only for Mac port?