[webkit-reviews] review canceled: [Bug 120833] [GTK] Desktop proxy settings are ignored inside the internal jhbuild : [Attachment 210715] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has canceled Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 120833: [GTK] Desktop proxy settings are ignored inside the internal
jhbuild
https://bugs.webkit.org/show_bug.cgi?id=120833

Attachment 210715: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=210715&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
After some investigation, I realized that we can not use the trick of setting
some configuration values in the memory backend from jhbuildrc (as suggested,
based on the presence of the typical environment variables) because the memory
backend provides in-process persistence only, and the jhbuild shell is not
actually the process we are interested in, but the apps we launch in that
environment (e.g. MiniBrowser), which won't read anything we set from
jhbuildrc.

So, after talking to Gustavo in IRC, we believe that a better approach that
will make lives easier for everybody without compromising the default
configuration, would be to add dconf as an optional jhbuild module AND remove
the line from jhbuildrc that explicitly sets the memory backend just for the
sake of removing the usual warning you will see letting you know about that.

That way, someone willing to use the default behaviour won't have to do
anything different and just will get that warning (which IMHO is useful anyway,
to remind you what you are using), and someone willing to have access to the
global settings will just have to run Tools/jhbuild/jhbuild-wrapper --gtk build
dconf previously, pretty much as it's mentioned in
https://trac.webkit.org/wiki/WebKitGTK/StartHacking#PersistentGSettings.