[webkit-reviews] review granted: [Bug 120775] [Qt][WK2] Cached credentials not cleared between tests : [Attachment 210624] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 120775: [Qt][WK2] Cached credentials not cleared between tests
https://bugs.webkit.org/show_bug.cgi?id=120775

Attachment 210624: Patch
https://bugs.webkit.org/attachment.cgi?id=210624&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210624&action=review


r=me
I don't like starting to pollute this file with platform code, but I can't
think of a better place to do this.

> Source/WebCore/testing/Internals.cpp:282
> +	   QNetworkAccessManager* qnam = context->networkAccessManager();
> +	   if (qnam)
> +	       qnam->clearAccessCache();

Nit: Could be shrunk to "if (QNetworkAccessManager* qnam =
context->networkAccessManager())".