[webkit-reviews] review granted: [Bug 120726] When deleting editable content, typing style should be reset when moving into another node. : [Attachment 210597] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Arpita Bahuguna
<a.bah at samsung.com>'s request for review:
Bug 120726: When deleting editable content, typing style should be reset when
moving into another node.
https://bugs.webkit.org/show_bug.cgi?id=120726

Attachment 210597: Patch
https://bugs.webkit.org/attachment.cgi?id=210597&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=210597&action=review


> Source/WebCore/editing/DeleteSelectionCommand.cpp:283
>      // typing style at the start of the selection, nor is there a reason to 

>      // compute the style at the start of the selection after deletion (see
the 
>      // early return in calculateTypingStyleAfterDelete).

Perhaps you should update this comment as well.

> LayoutTests/editing/deleting/maintain-style-after-delete-expected.txt:3
> +Dump of markup 1:

This is rather mysterious title.

> LayoutTests/editing/deleting/maintain-style-after-delete.html:19
> +Markup.dump(test);

You can pass in a description as the second argument. e.g. "Deleting the blue
text and typing O immediately after it. O should be blue below"

> LayoutTests/editing/deleting/maintain-style-after-delete.html:24
> +Markup.dump(test);

e.g. "Deleting O and the preceding space, then typing W. W should not be in
blue below"