[webkit-reviews] review granted: [Bug 120373] AX: aria-relevant does not expose AXARIARelevant : [Attachment 210622] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 120373: AX: aria-relevant does not expose AXARIARelevant
https://bugs.webkit.org/show_bug.cgi?id=120373

Attachment 210622: patch
https://bugs.webkit.org/attachment.cgi?id=210622&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210622&action=review


> Source/WebCore/accessibility/AccessibilityObject.cpp:1562
> +	   || hasAttribute(aria_atomicAttr)
> +	   || hasAttribute(aria_busyAttr)
> +	   || hasAttribute(aria_controlsAttr)
> +	   || hasAttribute(aria_describedbyAttr)
> +	   || hasAttribute(aria_disabledAttr)
> +	   || hasAttribute(aria_haspopupAttr)
> +	   || hasAttribute(aria_invalidAttr)
> +	   || hasAttribute(aria_labelAttr)
> +	   || hasAttribute(aria_labelledbyAttr)
> +	   || hasAttribute(aria_relevantAttr);

Eventually this is going to get really slow. Every one of these is a separate
hash table lookup.