[webkit-reviews] review granted: [Bug 120792] WKFullScreenWindowController extends lifetime of WKView, deleting it at a wrong time : [Attachment 210659] proposed fix

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 120792: WKFullScreenWindowController extends lifetime of WKView, deleting
it at a wrong time
https://bugs.webkit.org/show_bug.cgi?id=120792

Attachment 210659: proposed fix
https://bugs.webkit.org/attachment.cgi?id=210659&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
LGTM, r=me with nit.

The only thing I worry about is the lifetime of the WKFullScreenWindow being
extended (due to being retained by something other than the WKView, or by a
-performSelector:afterDelay:) somehow, and thus holding onto an invalid
_webView pointer.

Perhaps the _webView could stay unretained, but the -setWebView: method could
also stay, and would be cleared out by WKView in its own -dealloc method?  We
could even add a "@property (assign) WKView* webView" declaration to make the
semantic explicit.