[webkit-reviews] review granted: [Bug 120790] Clean up wtf/Compiler.h : [Attachment 210653] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 120790: Clean up wtf/Compiler.h
https://bugs.webkit.org/show_bug.cgi?id=120790

Attachment 210653: Patch
https://bugs.webkit.org/attachment.cgi?id=210653&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210653&action=review


> Source/WTF/ChangeLog:12
> +	   - Replace WTF_COMPILER_SUPPORTS_CXX_FINAL_CONTROL with a compiler
quirk for versions of clang
> +	     that have a buggy final implementation and fix a bug in the macro
where final would be disabled
> +	     for versions of clang where __clang_minor__ is less than 2,
regardless of the major version.

Whoops!

> Source/WTF/wtf/Compiler.h:57
> +// Disable final on versions of Apple clang earlier than 4.2 to avoid bugs
like http://webkit.org/b/119165 */

/* I think this file might need to be C compatible. */