[webkit-reviews] review requested: [Bug 120299] [GTK][WK2] a11y tests unconditionally launching a11y daemons : [Attachment 210470] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 120299: [GTK][WK2] a11y tests unconditionally launching a11y daemons
https://bugs.webkit.org/show_bug.cgi?id=120299

Attachment 210470: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=210470&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #0)
> I was checking the status of some GTK bots and I noticed that we had >600!!!
at-spi2-bus-launcher processes with their corresponding dbus-daemon processes
> 
> I think the problem is that we unconditionally launch them in
_start_accessibility_daemons() in run-gtk-tests

Actually, this should not be an issue since we already take care of terminating
the process that we start in _tear_down_testing_environment().

The problem was that, as silly as it might sound, we were using the wrong
variable name (_ally_bus_launcher) to keep a reference to that process, so
later on we were not terminating it properly (as we were expecting
_spi_bus_launcher in _tear_down_testing_environment()).