[webkit-reviews] review denied: [Bug 114354] [ATK] Adds an accessibility support to access a value of the color control element : [Attachment 210447] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 4 05:51:44 PDT 2013


Mario Sanchez Prada <mario at webkit.org> has denied  review:
Bug 114354: [ATK] Adds an accessibility support to access a value of the color
control element
https://bugs.webkit.org/show_bug.cgi?id=114354

Attachment 210447: Patch
https://bugs.webkit.org/attachment.cgi?id=210447&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #9)
> (From update of attachment 210447 [details])
> Rejecting attachment 210447 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
'--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02',
'validate-changelog', '--check-oops', '--non-interactive', 210447,
'--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
> 
> Full output: http://webkit-queues.appspot.com/results/1693587

Oops! It seems the ChangeLog was kind of duplicated (and I missed that one for
some reason, too).

Please fix it and provide a new patch


More information about the webkit-reviews mailing list