[webkit-reviews] review granted: [Bug 114354] [ATK] Adds an accessibility support to access a value of the color control element : [Attachment 210447] Patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 114354: [ATK] Adds an accessibility support to access a value of the color
control element
https://bugs.webkit.org/show_bug.cgi?id=114354

Attachment 210447: Patch
https://bugs.webkit.org/attachment.cgi?id=210447&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #6)
> (In reply to comment #2)
> > I think it would be more accurate to implement AtkValue interface [1] for
this kind of input elements, instead of partly implementing AtkText, which
seems a bit "forced" to me in this case.
> > 
> > API, joanie... what do you think?
> > 
> 
> I do not have any other arguments than those what joanie said. I agree with
her.

It seems you both agree on that and, on top of that, I also can't see a better
solution so I'm fine with that.

We'll probably need to rebaseline the results for GTK too, but that's something
we can do once it's landed.