[webkit-reviews] review granted: [Bug 17619] defining line height affects height of text box : [Attachment 210346] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted gur.trio at gmail.com's request for
review:
Bug 17619: defining line height affects height of text box
https://bugs.webkit.org/show_bug.cgi?id=17619

Attachment 210346: Patch
https://bugs.webkit.org/attachment.cgi?id=210346&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210346&action=review


>>> Source/WebCore/css/html.css:425
>>> +}
>> 
>> Trying to prevent this with a user-agent stylesheet change will make
line-height value of normal visible in getComputedStyle on the input element;
because of that I think this is wrong. Unless the specification or standard
practice in other browsers is to return "normal" as the computed style for the
input element. Instead we can turn off the line-height inside the shadow DOM
constructed by the input element somewhere in the RenderTextControl class.
>> 
>> Can you please test what getComputedStyle does in these other browsers?
> 
> The Test case input-line-height.html shows the following results. The test
case compares getComputedStyle's line-height with style's line-height
> 
> IE : FAIL for all inputs i.e getComputedStyle's line-height and style's
line-height are same (both values show 50px)
> Mozilla : PASS for all inputs i.e getComputedStyle's line-height and style's
line-height are different.(getComputedStyle's line height shows 16px and
style's line height shows 50px)
> 
> Mozilla as I can see is doing through .css

OK, lets go with the CSS solution.

There should be a space after the colon to match the rest of the html.css file.